Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add SDPLR to list of solvers #3644

Merged
merged 4 commits into from
Jan 8, 2024
Merged

[docs] Add SDPLR to list of solvers #3644

merged 4 commits into from
Jan 8, 2024

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 28, 2023 •
edited by odow
Loading

I'm already opening this PR even if it's not released to see if the README passes the tests

Basic

  • Check that the solver is a registered Julia package, needs Enable ConstraintDual tests SDPLR.jl#19
  • Check that the solver supports the long-term support release of Julia
  • Check that the solver has a MathOptInterface wrapper
  • Check that the tests call MOI.Test.runtests. Some test excludes are
    permissible, but the reason for skipping a particular test should be
    documented.
  • Check that the README and/or documentation provides an example of how to
    use the solver with JuMP

Documentation

  • Add a new row to the table in docs/src/installation.md

Optional

  • Add package metadata to docs/packages.toml

cc @sburer

@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (232a95d) 98.28% compared to head (90394bc) 98.28%.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3644   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          43       43           
  Lines        5640     5640           
=======================================
  Hits         5543     5543           
  Misses         97       97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member

odow commented Jan 2, 2024

I wonder if we should move it to jump-dev before tagging.

odow
odow reviewed Jan 3, 2024
View reviewed changes
docs/packages.toml Outdated Show resolved Hide resolved
@odow odow merged commit a94dedc into master Jan 8, 2024
12 checks passed
@odow odow deleted the bl/sdplr branch January 8, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odow odow odow left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegat @odow